https://gitlab.synchro.net/main/sbbs/-/commit/5d903235ca2629f59dc78999
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Log errno description upon QWK pack mutex file creation failure

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/339599be4e8c05ed8e3fabe9
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix MSLT and MSLD response for QWK packet filename in root directory

Reusing the variable 'str' here for multiple purposes meant the QWK packet filename was overwritten by the owner name (the system's BBS-ID):

mlsd

229 Entering Extended Passive Mode (|||2001|)
150 Opening ASCII mode data connection for MLSD.
Type=file;Perm=r;UNIX.ownername=VERT; 00index
Type=cdir;Perm=elc;UNIX.ownername=VERT; /
Type=file;Perm=r;UNIX.ownername=VERT; VERT

That last file there should have been "VERT.qwk"

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3a25ed550b4f5d6563da0d8a
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Use safe string copying in get_owner_name() via strlcpy()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bb4ccdaad2c07262560ddab9
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Restore ftpalias.cfg support for MLSx commands

Support was accidentally removed as part of commit 0d01544d, meaning
the ftpalias.cfg wasn't used at all in responses to the MLSx commands as reported by Max (WESTLINE) using Total Commander, FileZilla and Directory
opus. The traditional "LIST" commands still worked fine with ftpalias.cfg contents just fine.

The reason this code was accidentally removed was due to the errant
copy/pasted comparison with startup->html_index_file that did not belong here and made the block appear related to HTML index file generation. It was not. This was just a bug in the initial implementation of MLSx support in
commit d4deb4b3.

Also included in this commit:
- Return the date/size of the user's QWK packet file, if it exists, in MLSx
response.
- send_mlsx_entry() won't report negative time_t values as file modify dates
(flength returns -1 upon failure/file-not-found).
- get_owner_name() returns the string, making it easier to use in function
calls.

There appears to still be some work to do to make the MLSx commands fully compliant with RFC 3659 (e.g. "mlst filename" from ftpalias.cfg should work
but does not), but at least FileZilla displays ftpalias.cfg files and directories correctly now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e1b0164230ba4987cae0c3df
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Mostly time_t printfs, but also an odd bit where it's printing a
value that's not an off_t as one.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ca7156dc5215b928bf5a689
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Reduce log severity of QWK-packet removal error log message to WARNING

This allows each call to ftp_remote() to specify the log level for any remove failure. All others file-removal failures will continue to log at ERROR level.

I get this particular (harmless) error a lot, so just reducing to warning:
ftp ... !ERROR 13 (Permission denied) (line 860) removing file: path/to/*.qwk

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/05420809878c8fd7f272fa87
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
ftp_remove() returns a bool (not an int) now, so do the right thing

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/51ce7e6f71c2009c1804679f
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Attempt to fix issue #799

receive_thread() needs to use the control session correctly for
TLS connections.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/17912ca377006ca652483b1e
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
IP addresses are logged (most) everywhere else in square brackets

There are still places where it could be logged in <> (if username is not yet known).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ffba326dad6263eedc29ed94
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Fix the "ERROR x getting data user y" log message (usernum was 0).

Add the errno value to help root-cause.

We really should be using safe_strerror() everywhere.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/569efded81398f71ad35f70b
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Use safe_strerror() in place of strerror() - everything multithreaded should

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6fc2a6b6ff98fab8f98bf955
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
A little beautification of errno logging

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8b4d02103bb4a63ffcc360f3
Modified Files:
src/sbbs3/ftpsrvr.c
Log Message:
Correct initialization of fmutex_t so the file descriptor is -1

For some reason, MSVC was initializing the time_t (second element of the struct) to -1, not the int fd (the first element), which was initialized to
0. Weird.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/ftpsrvr.c
By: Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Mon Nov 18 2024 01:50 am

For some reason, MSVC was initializing the time_t (second element of the struct) to -1, not the int fd (the first element), which was initialized to 0. Weird.

Actually, this assessment was wrong. fmutex_open() was memsetting the fmutex_t to zero.
--
digital man (rob)

Synchronet/BBS Terminology Definition #88:
UART = Universal Asynchronous Receiver/Transmitter
Norco, CA WX: 61.5øF, 38.0% humidity, 2 mph W wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net